[AIBundle] Cache store configuration improved #293
Merged
+190
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
Guikingone
force-pushed
the
store/cache_fix
branch
from
47ab79e to
387d719
Compare
OskarStark
reviewed
Aug 8, 2025
Guikingone
force-pushed
the
store/cache_fix
branch
from
546c2d9 to
2368215
Compare
chr-hertel
reviewed
Aug 9, 2025
Guikingone
force-pushed
the
store/cache_fix
branch
2 times, most recently
from
3680a9e to
987fd0a
Compare
chr-hertel
reviewed
Aug 10, 2025
OskarStark
approved these changes
Aug 11, 2025
chr-hertel
reviewed
Aug 11, 2025
Guikingone
force-pushed
the
store/cache_fix
branch
3 times, most recently
from
001c006 to
d0d9815
Compare
Guikingone
force-pushed
the
store/cache_fix
branch
2 times, most recently
from
220e3b6 to
45b6de4
Compare
chr-hertel
reviewed
Aug 14, 2025
src/store/src/CacheStore.php
Outdated
There was a problem hiding this comment.
Let's remove the CacheItemPoolInterface then here completely 👍
There was a problem hiding this comment.
Hum nope, it's required for the static analysis, without the CacheItemPoolInterface, PHPStan isn't capable of resolving the methods from CIP.
There was a problem hiding this comment.
The only way to allows it to resolve it is by adding:
private CacheInterface&CacheItemPoolInterface $cache,
|
Needs a rebase after #318 |
Guikingone
force-pushed
the
store/cache_fix
branch
from
45b6de4 to
634aac4
Compare
chr-hertel
approved these changes
Aug 15, 2025
chr-hertel
force-pushed
the
store/cache_fix
branch
from
e11e413 to
6e1c982
Compare
|
Thank you @Guikingone. |
chr-hertel
added a commit
that referenced
this pull request
Aug 16, 2025
…-hertel) This PR was merged into the main branch. Discussion ---------- [Examples] Add symfony/cache as dependency for examples | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Related to #257 and #293 Commits ------- e641c09 Add symfony/cache as dependency for examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
The configuration wasn't complete enough to handle custom strategy / key for the cache store, here's the fix, tests are validated (both in the project and in a custom project too).