Fix array_merge() fatal error with string payloads in ModelClient imp… #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamyHakam
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
changed the title
|
This breaks some huggingface examples, and embeddings - for example for openai. Let's discuss in #326 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lementations
Issue
The
ModelClientInterfaceallows array|string $payload, but all implementations usearray_merge($payload, $options)without type checking, causing fatal errors when string payloads are passed.Fix
Remove unnecessary string support from the interface since all implementations expect arrays: