[Platform][Ollama] Support streaming output #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicalor
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Bug
carsonbot
changed the title
logicalor
changed the title
|
Can you please add an example in examples/ directory? Thanks |
OskarStark
changed the title
@OskarStark updated with an example |
|
Thanks It looks like your committer email is not associated with your GitHub account |
@OskarStark thanks, hadn't noticed that. Added. |
Guikingone
reviewed
Aug 22, 2025
Guikingone
reviewed
Aug 23, 2025
Guikingone
reviewed
Aug 23, 2025
chr-hertel
reviewed
Aug 24, 2025
chr-hertel
reviewed
Aug 24, 2025
|
which ollama version do you use? |
chr-hertel
reviewed
Aug 24, 2025
chr-hertel
requested changes
Aug 24, 2025
There was a problem hiding this comment.
Thanks @logicalor for reporting and working on this - we need this :)
Made some comments, but i think all in all we're close to merging it 👍
Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
@chr-hertel I was running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both a bug fix and a feature? Support streaming output from Ollama, preventing an error being thrown if streaming output is sent with the chat request.