[Agent] Expose Agent model #348
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
|
My heart always feels a bit sad when exposing stuff, but i think your use-case is valid 👍 Regarding the interface I'm a bit torn but currently in favor of adding it as well. 🤔 |
I was hesitating about it because:
Do you confirm I should update the interface in this PR @chr-hertel or you prefer another opinion ? |
chr-hertel
approved these changes
Aug 24, 2025
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #344 @OskarStark
Do you think it could be ok to expose the Agent model ?
It would be useful to access data like model name for logging purpose (without the need for reflection class).
But I'm dunno if it should be in the AgentInterface, your call.