Skip to content

Conversation

glengemann
Copy link
Contributor

@glengemann glengemann commented Aug 30, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #...
License MIT

Christopher, I think we need to register the normalizer contract so that it’s available when using the Symfony bundle.

@carsonbot carsonbot added AI Bundle Issues & PRs about the AI integration bundle Feature New feature Status: Needs Review labels Aug 30, 2025
@OskarStark OskarStark requested a review from Copilot August 30, 2025 11:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the OpenAI contract registration in the Symfony AI bundle to use the proper factory method instead of manually configuring the AudioNormalizer dependency.

  • Replaces manual contract configuration with factory-based registration
  • Switches from parent service pattern to direct factory instantiation
  • Updates import to use OpenAiContract class

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guillermo, i think you are right :)

@chr-hertel chr-hertel added Bug Something isn't working and removed Feature New feature labels Aug 31, 2025
@chr-hertel
Copy link
Member

Thank you @glengemann.

@chr-hertel chr-hertel merged commit 4f83f33 into symfony:main Aug 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Bundle Issues & PRs about the AI integration bundle Bug Something isn't working Status: Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants