[Platform] Fix doc type on FileNormalizer #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
carsonbot
changed the title
xabbuh
approved these changes
Aug 31, 2025
OskarStark
approved these changes
Aug 31, 2025
derrabus
pushed a commit
to derrabus/symfony-ai
that referenced
this pull request
Sep 12, 2025
…lexible message IDs (symfony#384) This PR updates the message ID type from `TimeBasedUidInterface` to `AbstractUid&TimeBasedUidInterface` using PHP's intersection types. This change provides more flexibility while maintaining type safety. Using the intersection type `AbstractUid&TimeBasedUidInterface` ensures that: - ✅ Both `toRfc4122()` (from AbstractUid) and `getDateTime()` (from TimeBasedUidInterface) are available - ✅ Implementations can use any time-based UID type (UUID v1/v6/v7 or ULID) - ✅ Type safety is maintained - ✅ All existing tests pass without modification - Updated `MessageInterface::getId()` return type - Updated all message implementations (AssistantMessage, SystemMessage, UserMessage, ToolCallMessage) - Updated anonymous class in tests 1. **Flexibility**: Users can now implement messages with either UUID or ULID 2. **Type Safety**: The intersection type guarantees all necessary methods are available 3. **Future Proof**: Any new Symfony UID types that extend AbstractUid and implement TimeBasedUidInterface will work None - this is backwards compatible since all existing UUID implementations already satisfy the new type constraint. All existing tests pass. The implementation has been verified to work with both UUID and ULID.
derrabus
pushed a commit
to derrabus/symfony-ai
that referenced
this pull request
Sep 12, 2025
…eBasedUidInterface` for flexible message IDs (OskarStark) This PR was merged into the main branch. Discussion ---------- [Platform] Use intersection type `AbstractUid&TimeBasedUidInterface` for flexible message IDs | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#384 Commits ------- 115a9e1 feat: use intersection type `AbstractUid&TimeBasedUidInterface` for flexible message IDs (symfony#384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #357