Skip to content

Conversation

chr-hertel
Copy link
Member

Q A
Bug fix? no
New feature? no
Docs? no
Issues
License MIT

Follows #381

@chr-hertel chr-hertel added the Run examples Issues & PRs about the example scripts label Aug 31, 2025
@chr-hertel chr-hertel requested a review from OskarStark as a code owner August 31, 2025 07:36
@carsonbot carsonbot changed the title Add example for RAG with ChromaDB [Examples] Add example for RAG with ChromaDB Aug 31, 2025
@chr-hertel chr-hertel merged commit 631027f into main Aug 31, 2025
13 checks passed
@OskarStark OskarStark deleted the example-chroma-rag branch September 4, 2025 12:42
derrabus pushed a commit to derrabus/symfony-ai that referenced this pull request Sep 12, 2025
Remove the `suggest` section from composer.json and add explicit runtime
checks
that throw exceptions with helpful composer require commands when
optional
dependencies are missing.

This provides better developer experience by:
- Giving clear error messages when optional dependencies are needed
- Providing the exact composer command to install missing packages
- Following Symfony's pattern for handling optional dependencies

Optional dependencies now throw exceptions instead of
silently failing when the required packages are not installed.

---------

Co-authored-by: Claude <noreply@anthropic.com>
derrabus pushed a commit to derrabus/symfony-ai that referenced this pull request Sep 12, 2025
…ecks (OskarStark)

This PR was merged into the main branch.

Discussion
----------

refactor: replace composer suggests with runtime checks

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  |no
| Docs?         | no
| Issues        | Fix symfony#76
| License       | MIT

Cherry picking php-llm/llm-chain#385

> Remove the `suggest` section from composer.json and add explicit runtime checks
that throw exceptions with helpful composer require commands when optional
dependencies are missing.
>
> This provides better developer experience by:
> - Giving clear error messages when optional dependencies are needed
> - Providing the exact composer command to install missing packages
> - Following Symfony's pattern for handling optional dependencies
>
> Optional dependencies now throw exceptions instead of silently failing when the required packages are not installed.

Commits
-------

95cd020 refactor: replace composer suggests with runtime checks (symfony#385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Run examples Issues & PRs about the example scripts Status: Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants