[Examples][ClickHouse] Add RAG example #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Run examples
OskarStark
changed the title
|
Thank you @Guikingone. |
derrabus
pushed a commit
to derrabus/symfony-ai
that referenced
this pull request
Sep 12, 2025
…#389) ## Summary This PR updates the PHPStan configuration to use an error identifier instead of a regex pattern for ignoring array type errors in tests. ## Changes - Replace regex pattern with identifier ## Benefits Using error identifiers is the recommended approach because: - **More stable**: Identifiers don't change across PHPStan versions, unlike error message text - **Cleaner**: Easier to read and understand the intent - **Maintainable**: Less prone to breaking if error message wording changes ## Testing PHPStan analysis passes with the new configuration.
derrabus
pushed a commit
to derrabus/symfony-ai
that referenced
this pull request
Sep 12, 2025
…ex pattern (OskarStark) This PR was merged into the main branch. Discussion ---------- [Agent] Use PHPStan error identifier instead of regex pattern | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#389 Commits ------- 611206b chore: use PHPStan error identifier instead of regex pattern (symfony#389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
Here's the rag example for
Clickhouseas discussed in #335