Skip to content

[Platform] Add Scaleway #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

[Platform] Add Scaleway #394

merged 1 commit into from
Sep 25, 2025

Conversation

daFish
Copy link
Contributor

@daFish daFish commented Sep 1, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Docs? yes/no
Issues References #16
License MIT

This PR adds Scaleway as a supported Platform.

Models are (excerpt): gpt-oss-120b, qwen3-235b-a22b-instruct-2507, gemma-3-27b-it

API is compatible with OpenAI API.

Todos:

  • Examples (Chat, Embeddings, Vision)
  • Tests
  • Documentation

@carsonbot carsonbot added Feature New feature Platform Issues & PRs about the AI Platform component Status: Needs Review labels Sep 1, 2025
@daFish daFish force-pushed the feat/platform-scaleway branch from 081a03e to 8211b77 Compare September 1, 2025 12:49
@daFish daFish marked this pull request as draft September 1, 2025 12:52
OskarStark
OskarStark reviewed Sep 1, 2025
View reviewed changes
welcoMattic
welcoMattic reviewed Sep 1, 2025
View reviewed changes
@daFish daFish force-pushed the feat/platform-scaleway branch from 8211b77 to 8dded69 Compare September 1, 2025 13:02
@daFish
Copy link
Contributor Author

daFish commented Sep 1, 2025

First round of comments adressed - thanks @OskarStark and @welcoMattic.

@daFish
Copy link
Contributor Author

daFish commented Sep 1, 2025

@chr-hertel @OskarStark Should the configuration of the bundle be in a separate PR?

welcoMattic
welcoMattic reviewed Sep 1, 2025
View reviewed changes
src/platform/src/Bridge/Scaleway/Scaleway.php Outdated
Comment on lines 41 to 48
Capability::INPUT_MESSAGES,
Capability::INPUT_IMAGE,
Capability::INPUT_PDF,
Capability::INPUT_MULTIPLE,
Capability::OUTPUT_TEXT,
Capability::OUTPUT_STREAMING,
Capability::OUTPUT_STRUCTURED,
Capability::TOOL_CALLING,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's done for other platforms, we will need to provide examples for most of these capabilities. (I'm currently doing it for Perplexity :D )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in the process of clustering various capabilities to models as not all have the same.

@OskarStark
Copy link
Contributor

@chr-hertel @OskarStark Should the configuration of the bundle be in a separate PR?

No, I prefer it here in this PR, thanks

OskarStark
OskarStark reviewed Sep 2, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 2, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 2, 2025
View reviewed changes
@OskarStark OskarStark changed the title [Platform] (WIP) Add Scaleway platform [Platform] Add Scaleway platform Sep 2, 2025
@OskarStark OskarStark changed the title [Platform] Add Scaleway platform [Platform] Add Scaleway Sep 2, 2025
@daFish
Copy link
Contributor Author

daFish commented Sep 3, 2025

Added support for embeddings with an example.

@daFish daFish force-pushed the feat/platform-scaleway branch from f5df13e to d5510fc Compare September 3, 2025 12:12
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
@daFish daFish force-pushed the feat/platform-scaleway branch from 27dc8c5 to f13c5f6 Compare September 3, 2025 12:26
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
@daFish daFish force-pushed the feat/platform-scaleway branch 2 times, most recently from d37e26f to accb842 Compare September 12, 2025 05:22
OskarStark
OskarStark reviewed Sep 17, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 17, 2025
View reviewed changes
@OskarStark
Copy link
Contributor

Needs a rebase

@daFish daFish force-pushed the feat/platform-scaleway branch 3 times, most recently from d6838b7 to 30e4973 Compare September 22, 2025 13:40
OskarStark
OskarStark reviewed Sep 22, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 22, 2025
View reviewed changes
@daFish daFish force-pushed the feat/platform-scaleway branch from 30e4973 to 9f2efd4 Compare September 22, 2025 16:25
@daFish daFish marked this pull request as ready for review September 22, 2025 16:25
OskarStark
OskarStark reviewed Sep 22, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 22, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 22, 2025
View reviewed changes
@OskarStark
Copy link
Contributor

Please add tests

@daFish
Copy link
Contributor Author

daFish commented Sep 24, 2025

I am in the process of writing the tests. Should be done be tomorrow. Sorry for the delay.

@OskarStark
Copy link
Contributor

No worries, take your time. Thanks for the feedback

@daFish daFish force-pushed the feat/platform-scaleway branch from 9f2efd4 to ed62d06 Compare September 25, 2025 14:53
@daFish
Copy link
Contributor Author

daFish commented Sep 25, 2025

@OskarStark Added the missing tests and also added more examples.

@daFish daFish force-pushed the feat/platform-scaleway branch from ed62d06 to 9fde21a Compare September 25, 2025 14:54
@daFish daFish force-pushed the feat/platform-scaleway branch from 9fde21a to 5a162c5 Compare September 25, 2025 14:59
chr-hertel
chr-hertel approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully - thank you @daFish!

@chr-hertel
Copy link
Member

Thank you @daFish.

@chr-hertel chr-hertel merged commit 0748a72 into symfony:main Sep 25, 2025
15 checks passed
@daFish daFish deleted the feat/platform-scaleway branch September 26, 2025 05:27
@daFish
Copy link
Contributor Author

daFish commented Sep 26, 2025

My pleasure. 🙇🏻

@chr-hertel chr-hertel mentioned this pull request Sep 26, 2025
Merged
chr-hertel added a commit that referenced this pull request Sep 26, 2025
@chr-hertel
minor #684 [Platform] Remove unnecessary import aliases (chr-hertel)
0252ac5 
This PR was merged into the main branch.

Discussion
----------

[Platform] Remove unnecessary import aliases

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        |
| License       | MIT

Follows #394 & #388

Commits
-------

b5033cd Remove unnecessary import aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic left review comments

@OskarStark OskarStark OskarStark left review comments

@chr-hertel chr-hertel chr-hertel approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
Feature New feature Platform Issues & PRs about the AI Platform component Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daFish @OskarStark @chr-hertel @welcoMattic @carsonbot