Skip to content

[Agent][Demo][Platform] Replace self::assert* with $this->assert* in test files #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

[Agent][Demo][Platform] Replace self::assert* with $this->assert* in test files #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions demo/tests/SmokeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public function testIndex()
$client = static::createClient();
$client->request('GET', '/');

self::assertResponseIsSuccessful();
self::assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo');
self::assertSelectorCount(5, '.card');
$this->assertResponseIsSuccessful();
$this->assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo');
$this->assertSelectorCount(5, '.card');
}

#[DataProvider('provideChats')]
Expand All @@ -37,9 +37,9 @@ public function testChats(string $path, string $expectedHeadline)
$client = static::createClient();
$client->request('GET', $path);

self::assertResponseIsSuccessful();
self::assertSelectorTextSame('h4', $expectedHeadline);
self::assertSelectorCount(1, '#chat-submit');
$this->assertResponseIsSuccessful();
$this->assertSelectorTextSame('h4', $expectedHeadline);
$this->assertSelectorCount(1, '#chat-submit');
}

/**
Expand Down
6 changes: 3 additions & 3 deletions src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function testGetDefinition()
/** @var Tool[] $metadatas */
$metadatas = iterator_to_array($this->factory->getTool(ToolRequiredParams::class));

self::assertToolConfiguration(
$this->assertToolConfiguration(
metadata: $metadatas[0],
className: ToolRequiredParams::class,
name: 'tool_required_params',
Expand Down Expand Up @@ -96,7 +96,7 @@ public function testGetDefinitionWithMultiple()

[$first, $second] = $metadatas;

self::assertToolConfiguration(
$this->assertToolConfiguration(
metadata: $first,
className: ToolMultiple::class,
name: 'tool_hello_world',
Expand All @@ -115,7 +115,7 @@ className: ToolMultiple::class,
],
);

self::assertToolConfiguration(
$this->assertToolConfiguration(
metadata: $second,
className: ToolMultiple::class,
name: 'tool_required_params',
Expand Down
2 changes: 1 addition & 1 deletion src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function testItPassesServerToolsFromOptions()
];
$httpClient = new MockHttpClient(
function ($method, $url, $options) {
self::assertJsonStringEqualsJsonString(
$this->assertJsonStringEqualsJsonString(
<<<'JSON'
{
"tools": [
Expand Down
8 changes: 4 additions & 4 deletions src/platform/tests/Message/AssistantMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ public function testDifferentMessagesHaveDifferentUids()
$message2 = new AssistantMessage('bar');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testSameMessagesHaveDifferentUids()
Expand All @@ -78,8 +78,8 @@ public function testSameMessagesHaveDifferentUids()
$message2 = new AssistantMessage('foo');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testMessageIdImplementsRequiredInterfaces()
Expand Down
8 changes: 4 additions & 4 deletions src/platform/tests/Message/SystemMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public function testDifferentMessagesHaveDifferentUids()
$message2 = new SystemMessage('bar');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testSameMessagesHaveDifferentUids()
Expand All @@ -60,8 +60,8 @@ public function testSameMessagesHaveDifferentUids()
$message2 = new SystemMessage('foo');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testMessageIdImplementsRequiredInterfaces()
Expand Down
8 changes: 4 additions & 4 deletions src/platform/tests/Message/ToolCallMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ public function testDifferentMessagesHaveDifferentUids()
$message2 = new ToolCallMessage($toolCall, 'baz');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testSameMessagesHaveDifferentUids()
Expand All @@ -66,8 +66,8 @@ public function testSameMessagesHaveDifferentUids()
$message2 = new ToolCallMessage($toolCall, 'bar');

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testMessageIdImplementsRequiredInterfaces()
Expand Down
8 changes: 4 additions & 4 deletions src/platform/tests/Message/UserMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ public function testDifferentMessagesHaveDifferentUids()
$message2 = new UserMessage(new Text('bar'));

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testSameMessagesHaveDifferentUids()
Expand All @@ -105,8 +105,8 @@ public function testSameMessagesHaveDifferentUids()
$message2 = new UserMessage(new Text('foo'));

$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
self::assertIsUuidV7($message1->getId()->toRfc4122());
self::assertIsUuidV7($message2->getId()->toRfc4122());
$this->assertIsUuidV7($message1->getId()->toRfc4122());
$this->assertIsUuidV7($message2->getId()->toRfc4122());
}

public function testMessageIdImplementsRequiredInterfaces()
Expand Down