[Platform][HuggingFace] Refactor test using MockClient properly
#451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 4, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | no |
| Issues | -- |
| License | MIT |
carsonbot
added
Status: Needs Review
Platform
OskarStark
force-pushed
the
refactor-huggingface-test-mockclient
branch
2 times, most recently
from
f67ed58 to
ca3b7eb
Compare
Replace reflection-based testing with MockClient and MockResponses to test URL generation and payload creation. Use callback-based assertions in MockHttpClient for cleaner and more direct URL validation at request time.
OskarStark
force-pushed
the
refactor-huggingface-test-mockclient
branch
from
ca3b7eb to
3aaa588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.