[Platform][HuggingFace] Add tests for Bridge components #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 4, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Docs? | no |
| Issues | -- |
| License | MIT |
carsonbot
added
Bug
OskarStark
commented
Sep 4, 2025
OskarStark
commented
Sep 4, 2025
Comment on lines
104
to
117
| #[TestDox('Sends correct HTTP request with null provider and task parameters')] | ||
| public function testModelsRequestParametersWithNullValues() | ||
| { | ||
| $httpClient = new MockHttpClient(function (string $method, string $url, array $options) { | ||
| $this->assertSame('GET', $method); | ||
| $this->assertStringStartsWith('https://huggingface.co/api/models', $url); | ||
| $this->assertArrayHasKey('query', $options); | ||
| $this->assertNull($options['query']['inference_provider']); | ||
| $this->assertNull($options['query']['pipeline_tag']); | ||
|
|
||
| return new JsonMockResponse([]); | ||
| }); | ||
|
|
||
| $apiClient = new ApiClient($httpClient); | ||
| $apiClient->models(null, null); | ||
| } |
There was a problem hiding this comment.
Does this make sense @chr-hertel or should we validate, that at least one needs to be set?
OskarStark
force-pushed
the
add-huggingface-tests
branch
2 times, most recently
from
8f0d8de to
43072f6
Compare
OskarStark
force-pushed
the
add-huggingface-tests
branch
from
a49cd46 to
eb67ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.