Skip to content

[Platform][Bedrock] Add tests for result converters #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

[Platform][Bedrock] Add tests for result converters #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
243 changes: 243 additions & 0 deletions src/platform/tests/Bridge/Bedrock/Anthropic/ClaudeResultConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,243 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Tests\Bridge\Bedrock\Anthropic;

use AsyncAws\BedrockRuntime\Result\InvokeModelResponse;
use AsyncAws\Core\Test\ResultMockFactory;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\Small;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Bridge\Anthropic\Claude;
use Symfony\AI\Platform\Bridge\Bedrock\Anthropic\ClaudeResultConverter;
use Symfony\AI\Platform\Bridge\Bedrock\RawBedrockResult;
use Symfony\AI\Platform\Exception\RuntimeException;
use Symfony\AI\Platform\Result\TextResult;
use Symfony\AI\Platform\Result\ToolCall;
use Symfony\AI\Platform\Result\ToolCallResult;

/**
* @author Oskar Stark <oskarstark@googlemail.com>
*/
#[CoversClass(ClaudeResultConverter::class)]
#[Small]
#[UsesClass(RawBedrockResult::class)]
#[UsesClass(TextResult::class)]
#[UsesClass(ToolCall::class)]
#[UsesClass(ToolCallResult::class)]
final class ClaudeResultConverterTest extends TestCase
{
#[TestDox('Supports Claude model')]
public function testSupports()
{
$converter = new ClaudeResultConverter();
$model = new Claude('claude-3-5-sonnet-20241022');

$this->assertTrue($converter->supports($model));
}

#[TestDox('Converts response with text content to TextResult')]
public function testConvertTextResult()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'type' => 'text',
'text' => 'Hello, world!',
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$converter = new ClaudeResultConverter();
$result = $converter->convert($rawResult);

$this->assertInstanceOf(TextResult::class, $result);
$this->assertSame('Hello, world!', $result->getContent());
}

#[TestDox('Converts response with tool use to ToolCallResult')]
public function testConvertToolCallResult()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'type' => 'tool_use',
'id' => 'toolu_01UM4PcTjC1UDiorSXVHSVFM',
'name' => 'get_weather',
'input' => ['location' => 'Paris'],
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$converter = new ClaudeResultConverter();
$result = $converter->convert($rawResult);

$this->assertInstanceOf(ToolCallResult::class, $result);
$toolCalls = $result->getContent();
$this->assertCount(1, $toolCalls);
$this->assertSame('toolu_01UM4PcTjC1UDiorSXVHSVFM', $toolCalls[0]->id);
$this->assertSame('get_weather', $toolCalls[0]->name);
$this->assertSame(['location' => 'Paris'], $toolCalls[0]->arguments);
}

#[TestDox('Converts response with multiple tool calls to ToolCallResult')]
public function testConvertMultipleToolCalls()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'type' => 'tool_use',
'id' => 'toolu_01',
'name' => 'get_weather',
'input' => ['location' => 'Paris'],
],
[
'type' => 'tool_use',
'id' => 'toolu_02',
'name' => 'get_time',
'input' => ['timezone' => 'UTC'],
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$converter = new ClaudeResultConverter();
$result = $converter->convert($rawResult);

$this->assertInstanceOf(ToolCallResult::class, $result);
$toolCalls = $result->getContent();
$this->assertCount(2, $toolCalls);

$this->assertSame('toolu_01', $toolCalls[0]->id);
$this->assertSame('get_weather', $toolCalls[0]->name);
$this->assertSame(['location' => 'Paris'], $toolCalls[0]->arguments);

$this->assertSame('toolu_02', $toolCalls[1]->id);
$this->assertSame('get_time', $toolCalls[1]->name);
$this->assertSame(['timezone' => 'UTC'], $toolCalls[1]->arguments);
}

#[TestDox('Prioritizes tool calls over text in mixed content')]
public function testConvertMixedContentWithToolUse()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'type' => 'text',
'text' => 'I will get the weather for you.',
],
[
'type' => 'tool_use',
'id' => 'toolu_01',
'name' => 'get_weather',
'input' => ['location' => 'Paris'],
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$converter = new ClaudeResultConverter();
$result = $converter->convert($rawResult);

// When tool calls are present, should return ToolCallResult regardless of text
$this->assertInstanceOf(ToolCallResult::class, $result);
$toolCalls = $result->getContent();
$this->assertCount(1, $toolCalls);
$this->assertSame('toolu_01', $toolCalls[0]->id);
}

#[TestDox('Throws RuntimeException when response has no content')]
public function testConvertThrowsExceptionWhenNoContent()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Response does not contain any content.');

$converter = new ClaudeResultConverter();
$converter->convert($rawResult);
}

#[TestDox('Throws RuntimeException when response has empty content array')]
public function testConvertThrowsExceptionWhenEmptyContent()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Response does not contain any content.');

$converter = new ClaudeResultConverter();
$converter->convert($rawResult);
}

#[TestDox('Throws RuntimeException when content has no text or type field')]
public function testConvertThrowsExceptionWhenNoTextOrType()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'invalid' => 'data',
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Response content does not contain any text or type.');

$converter = new ClaudeResultConverter();
$converter->convert($rawResult);
}

#[TestDox('Converts text content successfully')]
public function testConvertWithValidTypeButNoText()
{
$invokeResponse = ResultMockFactory::create(InvokeModelResponse::class, [
'body' => json_encode([
'content' => [
[
'type' => 'text',
'text' => 'Valid text content',
],
],
]),
]);
$rawResult = new RawBedrockResult($invokeResponse);

$converter = new ClaudeResultConverter();
$result = $converter->convert($rawResult);

$this->assertInstanceOf(TextResult::class, $result);
$this->assertSame('Valid text content', $result->getContent());
}
}
Loading