[Platform][VertexAI] Update ResultConverter
#466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentiminax
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Status: Needs Review
Bug
OskarStark
changed the title
ResultConverter
OskarStark
reviewed
Sep 5, 2025
OskarStark
reviewed
Sep 5, 2025
src/platform/tests/Bridge/VertexAi/Gemini/ResultConverterTest.php
Outdated
Show resolved
Hide resolved
OskarStark
force-pushed
the
fix/vertex-ai-result-converter
branch
from
fbf5c37 to
a46ddcf
Compare
|
... and one more bug fixed, thank you @pentiminax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #421 but for VertexAI bridge
This PR fixes a crash in the Gemini ResultConverter when handling responses that only contained executableCode and codeExecutionResult parts.
Rather than duplicating the code, I created a trait that is used in both bridges.
I also reused the same test fixtures.