Skip to content

[Store] Change vectorizeDocuments method to __invoke in Vectorizer #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
+13 −13
Merged

[Store] Change vectorizeDocuments method to __invoke in Vectorizer #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/store/src/Document/Vectorizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public function __construct(
) {
}

public function vectorizeDocuments(array $documents): array
public function __invoke(array $documents): array
{
if ($this->model->supports(Capability::INPUT_MULTIPLE)) {
$result = $this->platform->invoke($this->model, array_map(fn (TextDocument $document) => $document->content, $documents));
Expand Down
2 changes: 1 addition & 1 deletion src/store/src/Document/VectorizerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ interface VectorizerInterface
*
* @return VectorDocument[]
*/
public function vectorizeDocuments(array $documents): array;
public function __invoke(array $documents): array;
}
4 changes: 2 additions & 2 deletions src/store/src/Indexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ public function index(TextDocument|iterable $documents, int $chunkSize = 50): vo
++$counter;

if ($chunkSize === \count($chunk)) {
$this->store->add(...$this->vectorizer->vectorizeDocuments($chunk));
$this->store->add(...($this->vectorizer)($chunk));
$chunk = [];
}
}

if (\count($chunk) > 0) {
$this->store->add(...$this->vectorizer->vectorizeDocuments($chunk));
$this->store->add(...($this->vectorizer)($chunk));
}

$this->logger->debug(0 === $counter ? 'No documents to index' : \sprintf('Indexed %d documents', $counter));
Expand Down
18 changes: 9 additions & 9 deletions src/store/tests/Document/VectorizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function testVectorizeDocumentsWithBatchSupport()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount(3, $vectorDocuments);

Expand All @@ -88,7 +88,7 @@ public function testVectorizeDocumentsWithSingleDocument()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments([$document]);
$vectorDocuments = $vectorizer([$document]);

$this->assertCount(1, $vectorDocuments);
$this->assertInstanceOf(VectorDocument::class, $vectorDocuments[0]);
Expand All @@ -103,7 +103,7 @@ public function testVectorizeEmptyDocumentsArray()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments([]);
$vectorDocuments = $vectorizer([]);

$this->assertSame([], $vectorDocuments);
}
Expand All @@ -127,7 +127,7 @@ public function testVectorizeDocumentsPreservesMetadata()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount(2, $vectorDocuments);
$this->assertSame($metadata1, $vectorDocuments[0]->metadata);
Expand Down Expand Up @@ -158,7 +158,7 @@ public function testVectorizeDocumentsPreservesDocumentIds()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount(3, $vectorDocuments);
$this->assertSame($id1, $vectorDocuments[0]->id);
Expand Down Expand Up @@ -187,7 +187,7 @@ public function testVectorizeVariousDocumentCounts(int $count)
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount($count, $vectorDocuments);

Expand Down Expand Up @@ -226,7 +226,7 @@ public function testVectorizeDocumentsWithLargeVectors()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments([$document]);
$vectorDocuments = $vectorizer([$document]);

$this->assertCount(1, $vectorDocuments);
$this->assertEquals($vector, $vectorDocuments[0]->vector);
Expand All @@ -250,7 +250,7 @@ public function testVectorizeDocumentsWithSpecialCharacters()
$model = new Embeddings();

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount(3, $vectorDocuments);

Expand Down Expand Up @@ -313,7 +313,7 @@ public function convert(RawResultInterface $result, array $options = []): Result
$platform = new Platform([$handler], [$handler]);

$vectorizer = new Vectorizer($platform, $model);
$vectorDocuments = $vectorizer->vectorizeDocuments($documents);
$vectorDocuments = $vectorizer($documents);

$this->assertCount(2, $vectorDocuments);
$this->assertEquals($vectors[0], $vectorDocuments[0]->vector);
Expand Down