[Store][Qdrant] Allow setting filters on a query #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natewiebe13
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Feature
natewiebe13
force-pushed
the
qdrant-filters
branch
from
9bab221 to
80c5c73
Compare
|
I see the code quality error is due to the new option. Qdrant's filtering is pretty complex, not sure exactly the best way to express the option and how useful it would be to try to match it exactly (especially if it changes) |
Guikingone
reviewed
Sep 5, 2025
|
|
||
| /** | ||
| * @param array{ | ||
| * filter?: array<string, array>, |
There was a problem hiding this comment.
What about:
filter?: array<string, mixed>,
?
There was a problem hiding this comment.
Works for me. Tests are passing now too
natewiebe13
force-pushed
the
qdrant-filters
branch
from
80c5c73 to
333ee00
Compare
|
Can you add tests for this new filter? |
natewiebe13
force-pushed
the
qdrant-filters
branch
2 times, most recently
from
7547c7f to
275812d
Compare
Added |
chr-hertel
approved these changes
Sep 5, 2025
chr-hertel
force-pushed
the
qdrant-filters
branch
from
275812d to
ea6b8eb
Compare
|
Thank you @natewiebe13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting filters on queries