[Store] Rename __invoke methods in interfaces to descriptive names
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
added
Store
OskarStark
force-pushed
the
refactor/rename-invoke-methods
branch
from
f509670 to
d6b9f62
Compare
OskarStark
changed the title
__invoke methods to descriptive names__invoke methods in interfaces to descriptive names
OskarStark
force-pushed
the
refactor/rename-invoke-methods
branch
from
e27d798 to
0f2b756
Compare
|
It's so much better. It allows a class to implement multiple interfaces if necessary. |
|
Indeed 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @chr-hertel upfront.
Replace generic
__invokemethods with descriptive names:TransformerInterface::__invoke→transformVectorizerInterface::__invoke→vectorizeLoaderInterface::__invoke→loadThis improves code readability and makes the intent of each interface clearer. Updated all implementations and usages throughout the codebase.