[Platform][OpenAI] Add AuthenticationException for better error handling #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OpenAI API returns 401 (authentication error), users now get a clear AuthenticationException with the actual API error message instead of the confusing "Response does not contain choices" error. Changes: - Add AuthenticationException class for API authentication failures - Update OpenAI ResultConverter to check HTTP 401 status before processing - Add test coverage for authentication error scenarios Co-authored-by: Dmytro Liashko <dmlyashko@gmail.com> Fixes symfony#528
vitalii-kyktov
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Status: Needs Review
Platform
added 2 commits
September 12, 2025 13:10
Remove unnecessary JSON fields from mock response to focus on the essential error message extraction logic.
…Exception Keep the class clean without partial author information until the full implementation is complete.
vitalii-kyktov
force-pushed
the
openai-authentication-exception
branch
from
b3ecf66 to
193b56a
Compare
chr-hertel
approved these changes
Sep 12, 2025
|
Thank you @vitalii-kyktov. |
chr-hertel
added
the
Hackathon 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OpenAI API returns 401 (authentication error), users now get a clear AuthenticationException with the actual API error message instead of the confusing "Response does not contain choices" error.
Changes: