Skip to content

Conversation

OskarStark
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Docs? no
Issues --
License MIT

@carsonbot carsonbot changed the title Forbid declare strict types Forbid declare strict types Sep 12, 2025
@VincentLanglet
Copy link
Contributor

What about introducing a rule in PHP-CS-Fixer instead @OskarStark

It would be the opposite of https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/rules/strict/declare_strict_types.rst

@OskarStark
Copy link
Contributor Author

What about introducing a rule in PHP-CS-Fixer instead @OskarStark

Would love to have it and enabled for @Symfony group 😄
Open for a PR?

@OskarStark
Copy link
Contributor Author

fyi @nicolas-grekas 😄

@VincentLanglet
Copy link
Contributor

What about introducing a rule in PHP-CS-Fixer instead @OskarStark

Would love to have it and enabled for @Symfony group 😄 Open for a PR?

Sure, but seems like it need to be accepted first PHP-CS-Fixer/PHP-CS-Fixer#8877
If you want to +1 the idea

@OskarStark OskarStark force-pushed the forbid-declare-strict-types branch from 96f8fd1 to ec4dc2a Compare September 12, 2025 14:36
@OskarStark OskarStark force-pushed the forbid-declare-strict-types branch from 0ddac8c to fe9ce13 Compare September 12, 2025 14:41
@OskarStark OskarStark merged commit 3645393 into symfony:main Sep 12, 2025
11 of 12 checks passed
@OskarStark OskarStark deleted the forbid-declare-strict-types branch September 12, 2025 14:41
@chr-hertel chr-hertel added the Hackathon 2025 This issue or pull request was part of the Symfony AI Hackathon 2025 label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hackathon 2025 This issue or pull request was part of the Symfony AI Hackathon 2025 Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants