Skip to content

[Demo][Store] Add RssFeedLoader #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

[Demo][Store] Add RssFeedLoader #571

merged 1 commit into from
Sep 17, 2025

Conversation

ngrie
Copy link
Contributor

@ngrie ngrie commented Sep 12, 2025 •
edited by OskarStark
Loading

Q A
Bug fix? no
New feature? yes
Docs? no
Issues --
License MIT

OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 12, 2025
View reviewed changes
src/store/tests/Document/Loader/fixtures/blog.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move it to src/store/tests/fixtures/symfony-feed.xml

@OskarStark
Copy link
Contributor

Let's remove the FeedLoader from the demo and use the new RssFeedLoader, move the FeedLoaderTest to the store component and rename it properly. Update the demo to use your new loader instead of the FeedLoader.

@chr-hertel chr-hertel added the Hackathon 2025 This issue or pull request was part of the Symfony AI Hackathon 2025 label Sep 13, 2025
@carsonbot carsonbot changed the title [Store] Add RSS loader Add RSS loader Sep 13, 2025
@ngrie ngrie force-pushed the rss-loader branch 2 times, most recently from 23f82d7 to b1f7948 Compare September 14, 2025 20:41
@OskarStark OskarStark added Store Issues & PRs about the AI Store component Demo Issues & PRs about the demo application labels Sep 15, 2025
@carsonbot carsonbot changed the title Add RSS loader [Demo][Store] Add RSS loader Sep 15, 2025
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 15, 2025
View reviewed changes
@OskarStark OskarStark changed the title [Demo][Store] Add RSS loader [Demo][Store] Add RssLoader Sep 15, 2025
@OskarStark
Copy link
Contributor

Open for finishing this PR? :-)

@OskarStark
Copy link
Contributor

I pushed some changes to your branch

@ngrie
Copy link
Contributor Author

ngrie commented Sep 17, 2025

@OskarStark That's fine for me! I did not intend to leave this one unfinished, but I am still travelling for some more days and not spending that much time in front of a computer ...

@OskarStark
Copy link
Contributor

Enjoy your vacation, I will finish this one :-)

@OskarStark OskarStark changed the title [Demo][Store] Add RssLoader [Demo][Store] Add RssFeedLoader Sep 17, 2025
@OskarStark OskarStark marked this pull request as ready for review September 17, 2025 09:32
@OskarStark
Copy link
Contributor

I tested the indexer in the Demo app:
CleanShot 2025-09-17 at 12 24 43@2x

@OskarStark OskarStark force-pushed the rss-loader branch 3 times, most recently from 8b26536 to 4c070a6 Compare September 17, 2025 10:35
@OskarStark
Copy link
Contributor

Final test with debug output:
CleanShot 2025-09-17 at 12 57 13@2x

@OskarStark
Copy link
Contributor

And the example:
CleanShot 2025-09-17 at 13 00 46@2x

@OskarStark
Copy link
Contributor

Thanks Niklas for working on this feature, this is much appreciated.

@OskarStark OskarStark merged commit 937730c into symfony:main Sep 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
Demo Issues & PRs about the demo application Feature New feature Hackathon 2025 This issue or pull request was part of the Symfony AI Hackathon 2025 Status: Needs Review Store Issues & PRs about the AI Store component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngrie @OskarStark @chr-hertel @carsonbot