Skip to content

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Sep 13, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues Eases implementation of #514
License MIT

Summary

Restructures system_prompt configuration to nest include_tools for better organization and ergonomics.

Changes

  • Move include_tools from agent level to system_prompt level
  • Support both string (simple) and array (advanced) formats

Before

system_prompt: 'You are helpful.'
include_tools: true

After

simple

system_prompt: 'You are helpful.'

advanced

system_prompt:
    prompt: 'You are helpful.'
    include_tools: true

@OskarStark OskarStark self-assigned this Sep 13, 2025
@OskarStark OskarStark added the BC Break Breaking the Backwards Compatibility Promise label Sep 13, 2025
@carsonbot carsonbot added AI Bundle Issues & PRs about the AI integration bundle Feature New feature Status: Needs Review labels Sep 13, 2025
@OskarStark OskarStark force-pushed the feature/system-prompt-restructure branch 3 times, most recently from d480c52 to 9ff8d83 Compare September 13, 2025 06:55
@OskarStark OskarStark marked this pull request as draft September 13, 2025 07:14
@OskarStark OskarStark marked this pull request as ready for review September 13, 2025 08:32
@OskarStark OskarStark force-pushed the feature/system-prompt-restructure branch from d4a29d9 to 5f78680 Compare September 13, 2025 08:33
@OskarStark OskarStark merged commit a2da689 into symfony:main Sep 13, 2025
OskarStark added a commit that referenced this pull request Sep 13, 2025
…pt` key to `text` (OskarStark)

This PR was merged into the main branch.

Discussion
----------

[AI Bundle] Rename `system_prompt` to `prompt` and `prompt` key to `text`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | yes
| Issues        | Follows #576
| License       | MIT

- Renamed system_prompt configuration key to prompt for clearer naming
- Renamed nested 'prompt' key to 'text' in array configuration to avoid confusion
- Updated all configuration examples in demo
- Updated documentation with new configuration structure
- Updated all tests to use new configuration structure
- Maintained backward compatibility through configuration normalization

I prefer `text`, as this way, we can introduce `file` and validate that only one can be set. I am planning to support twig and json prompts in the future.

Commits
-------

2220387 [AI Bundle] Rename system_prompt to prompt and prompt key to text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Bundle Issues & PRs about the AI integration bundle BC Break Breaking the Backwards Compatibility Promise Feature New feature Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants