[AI Bundle][Ollama] Fix duplicate setFactory call for platform
#605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
AI Bundle
carsonbot
changed the title
OskarStark
changed the title
setFactory call for platform
OskarStark
force-pushed
the
fix-ollama-duplicate-factory
branch
from
748ba30 to
2c19d13
Compare
chr-hertel
approved these changes
Sep 16, 2025
|
Good catch, thanks @OskarStark. |
|
Wow, nice catch on this one, strange that it passed the tests 🤔 |
It just got overwritten, right? |
|
Yes, it's overwritten just after the call but still strange that I let it be merged "in its current shape", I should have seen it during the review 😅 |
|
No worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks wrong to me.
Follows #604 (comment)