Skip to content

Conversation

Guite
Copy link
Contributor

@Guite Guite commented Sep 17, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues
License MIT

Instead of always showing Response does not contain any content. or Response does not contain choices., this MR exposes the original error message from Gemini/OpeNAI.

For example: Error 400 - INVALID_ARGUMENT: A schema in GenerationConfig in the request exceeds the maximum allowed nesting depth..

@carsonbot carsonbot added Bug Something isn't working Status: Needs Review labels Sep 17, 2025
@carsonbot carsonbot changed the title show Gemini error details to simplify localisation of the cause show Gemini error details to simplify localisation of the cause Sep 17, 2025
@OskarStark OskarStark added the Platform Issues & PRs about the AI Platform component label Sep 17, 2025
@carsonbot carsonbot changed the title show Gemini error details to simplify localisation of the cause [Platform] show Gemini error details to simplify localisation of the cause Sep 17, 2025
@OskarStark OskarStark changed the title [Platform] show Gemini error details to simplify localisation of the cause [Platform][Gemini] Show error details to simplify localization of the cause Sep 17, 2025
@OskarStark
Copy link
Contributor

@chr-hertel this one is for you 😄

@Guite Guite changed the title [Platform][Gemini] Show error details to simplify localization of the cause [Platform][Gemini+OpenAI] Show error details to simplify localization of the cause Sep 18, 2025
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlooked this one - could use some sprintf for the exception message, please

@Guite
Copy link
Contributor Author

Guite commented Sep 29, 2025

added sprintf usage in b339241

@OskarStark
Copy link
Contributor

Thank you @Guite.

@OskarStark OskarStark merged commit 5434201 into symfony:main Sep 29, 2025
14 checks passed
OskarStark added a commit to OskarStark/ai that referenced this pull request Sep 29, 2025
…onverters

This adds comprehensive test coverage for the error handling improvements
introduced in symfony#608, ensuring detailed error information is properly
extracted and thrown as exceptions.
OskarStark added a commit that referenced this pull request Sep 29, 2025
This PR was squashed before being merged into the main branch.

Discussion
----------

[Platform] Add error handling tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | Follows #608
| License       | MIT

Commits
-------

cac9a7e [Platform] Add error handling tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Platform Issues & PRs about the AI Platform component Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants