-
-
Notifications
You must be signed in to change notification settings - Fork 102
[Platform][Gemini+OpenAI] Show error details to simplify localization of the cause #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chr-hertel this one is for you 😄 |
chr-hertel
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overlooked this one - could use some sprintf
for the exception message, please
added |
OskarStark
approved these changes
Sep 29, 2025
Thank you @Guite. |
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 29, 2025
…onverters This adds comprehensive test coverage for the error handling improvements introduced in symfony#608, ensuring detailed error information is properly extracted and thrown as exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Platform
Issues & PRs about the AI Platform component
Status: Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always showing
Response does not contain any content.
orResponse does not contain choices.
, this MR exposes the original error message from Gemini/OpeNAI.For example:
Error 400 - INVALID_ARGUMENT: A schema in GenerationConfig in the request exceeds the maximum allowed nesting depth.
.