Skip to content

[Demo] Fix tests #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

[Demo] Fix tests #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion .github/workflows/integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ env:
REQUIRED_PHP_EXTENSIONS: 'mongodb'

jobs:
php:
examples:
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -82,3 +82,35 @@ jobs:

- name: Run commands examples
run: php examples/commands/stores.php

demo:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.4'
tools: flex
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"

- name: Get composer cache directory
id: composer-cache
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT

- name: Cache demo dependencies
uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-demo-8.4-${{ hashFiles('demo/composer.json') }}
restore-keys: |
${{ runner.os }}-composer-demo-8.4

- name: Install demo dependencies
run: cd demo && composer install --no-progress --no-interaction --ansi

- name: Run demo tests
run: cd demo && vendor/bin/phpunit
19 changes: 13 additions & 6 deletions demo/src/Blog/FeedLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,22 @@ public function load(?string $source, array $options = []): iterable
$posts = [];
$crawler = new Crawler($result->getContent());
$crawler->filter('item')->each(function (Crawler $node) use (&$posts) {
$title = $node->filter('title')->text();
$title = $node->filter('title')->text() ?: '';
$link = $node->filter('link')->text() ?: '';
$description = $node->filter('description')->text() ?: '';
$contentEncoded = $node->filter('content\:encoded')->text();
$content = $contentEncoded ? (new Crawler($contentEncoded))->text() : '';
$author = $node->filter('dc\:creator')->text() ?: '';
$pubDate = $node->filter('pubDate')->text();

$posts[] = new Post(
Uuid::v5(Uuid::fromString('6ba7b810-9dad-11d1-80b4-00c04fd430c8'), $title),
$title,
$node->filter('link')->text(),
$node->filter('description')->text(),
(new Crawler($node->filter('content\:encoded')->text()))->text(),
$node->filter('dc\:creator')->text(),
new \DateTimeImmutable($node->filter('pubDate')->text()),
$link,
$description,
$content ?: '',
$author,
new \DateTimeImmutable($pubDate),
);
});

Expand Down
43 changes: 22 additions & 21 deletions demo/tests/Blog/FeedLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Exception\InvalidArgumentException;
use Symfony\Component\HttpClient\Exception\ClientException;
use Symfony\Component\HttpClient\MockHttpClient;
use Symfony\Component\HttpClient\Response\MockResponse;
use Symfony\Component\Uid\Uuid;
Expand All @@ -28,7 +30,7 @@ final class FeedLoaderTest extends TestCase
{
public function testLoadWithValidFeedUrl()
{
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/fixtures/symfony-feed.xml')));
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/../fixtures/symfony-blog.rss')));
$documents = iterator_to_array($loader->load('https://feeds.feedburner.com/symfony/blog'));

$this->assertCount(2, $documents);
Expand All @@ -40,12 +42,12 @@ public function testLoadWithValidFeedUrl()
$expectedFirstUuid = Uuid::v5(Uuid::fromString('6ba7b810-9dad-11d1-80b4-00c04fd430c8'), 'Save the date, SymfonyDay Montreal 2026!');
$this->assertEquals($expectedFirstUuid, $firstDocument->id);

$this->assertStringContainsString('Title: Save the date, SymfonyDay Montreal 2026!', $firstDocument->text);
$this->assertStringContainsString('From: Paola Suárez on 2025-09-11', $firstDocument->text);
$this->assertStringContainsString("We're thrilled to announce that SymfonyDay Montreal is happening on June 4, 2026!", $firstDocument->text);
$this->assertStringContainsString('Mark your calendars, tell your friends', $firstDocument->text);
$this->assertStringContainsString('Title: Save the date, SymfonyDay Montreal 2026!', $firstDocument->content);
$this->assertStringContainsString('From: Paola Suárez on 2025-09-11', $firstDocument->content);
$this->assertStringContainsString("We're thrilled to announce that SymfonyDay Montreal is happening on June 4, 2026!", $firstDocument->content);
$this->assertStringContainsString('Mark your calendars, tell your friends', $firstDocument->content);

$firstMetadata = $firstDocument->metadata->toArray();
$firstMetadata = $firstDocument->metadata;
$this->assertSame($expectedFirstUuid->toRfc4122(), $firstMetadata['id']);
$this->assertSame('Save the date, SymfonyDay Montreal 2026!', $firstMetadata['title']);
$this->assertSame('https://symfony.com/blog/save-the-date-symfonyday-montreal-2026?utm_source=Symfony%20Blog%20Feed&utm_medium=feed', $firstMetadata['link']);
Expand All @@ -61,11 +63,11 @@ public function testLoadWithValidFeedUrl()
$expectedSecondUuid = Uuid::v5(Uuid::fromString('6ba7b810-9dad-11d1-80b4-00c04fd430c8'), 'SymfonyCon Amsterdam 2025: Call for IT student volunteers: Volunteer, Learn & Connect!');
$this->assertEquals($expectedSecondUuid, $secondDocument->id);

$this->assertStringContainsString('Title: SymfonyCon Amsterdam 2025: Call for IT student volunteers: Volunteer, Learn & Connect!', $secondDocument->text);
$this->assertStringContainsString('From: Paola Suárez on 2025-09-10', $secondDocument->text);
$this->assertStringContainsString('🎓SymfonyCon Amsterdam 2025: Call for IT Student Volunteers!', $secondDocument->text);
$this->assertStringContainsString('Title: SymfonyCon Amsterdam 2025: Call for IT student volunteers: Volunteer, Learn & Connect!', $secondDocument->content);
$this->assertStringContainsString('From: Paola Suárez on 2025-09-10', $secondDocument->content);
$this->assertStringContainsString('🎓SymfonyCon Amsterdam 2025: Call for IT Student Volunteers!', $secondDocument->content);

$secondMetadata = $secondDocument->metadata->toArray();
$secondMetadata = $secondDocument->metadata;
$this->assertSame($expectedSecondUuid->toRfc4122(), $secondMetadata['id']);
$this->assertSame('SymfonyCon Amsterdam 2025: Call for IT student volunteers: Volunteer, Learn & Connect!', $secondMetadata['title']);
$this->assertSame('https://symfony.com/blog/symfonycon-amsterdam-2025-call-for-it-student-volunteers-volunteer-learn-and-connect?utm_source=Symfony%20Blog%20Feed&utm_medium=feed', $secondMetadata['link']);
Expand Down Expand Up @@ -108,45 +110,44 @@ public function testLoadWithHttpError()
{
$loader = new FeedLoader(new MockHttpClient(new MockResponse('', ['http_code' => 404])));

$this->expectException(\Symfony\Contracts\HttpClient\Exception\ClientException::class);
$this->expectException(ClientException::class);

iterator_to_array($loader->load('https://example.com/non-existent-feed.xml'));
}

public function testLoadWithMalformedXml()
{
$malformedXml = '<?xml version="1.0" encoding="UTF-8" ?><rss><channel><title>Test</title>';
$malformedXml = 'Not XML at all';

$loader = new FeedLoader(new MockHttpClient(new MockResponse($malformedXml)));
$documents = iterator_to_array($loader->load('https://example.com/malformed-feed.xml'));

$this->expectException(\Exception::class);

iterator_to_array($loader->load('https://example.com/malformed-feed.xml'));
$this->assertCount(0, $documents);
}

public function testLoadReturnsIterableOfTextDocuments()
{
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/fixtures/symfony-feed.xml')));
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/../fixtures/symfony-blog.rss')));
$result = $loader->load('https://feeds.feedburner.com/symfony/blog');

$this->assertIsIterable($result);

foreach ($result as $document) {
$this->assertInstanceOf(TextDocument::class, $document);
$this->assertInstanceOf(Uuid::class, $document->id);
$this->assertIsString($document->text);
$this->assertNotEmpty($document->text);
$this->assertIsArray($document->metadata->toArray());
$this->assertIsString($document->content);
$this->assertNotEmpty($document->content);
$this->assertInstanceOf(Metadata::class, $document->metadata);
}
}

public function testLoadGeneratesConsistentUuids()
{
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/fixtures/symfony-feed.xml')));
$loader = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/../fixtures/symfony-blog.rss')));
$documents1 = iterator_to_array($loader->load('https://feeds.feedburner.com/symfony/blog'));

// Load same feed again
$loader2 = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/fixtures/symfony-feed.xml')));
$loader2 = new FeedLoader(new MockHttpClient(MockResponse::fromFile(__DIR__.'/../fixtures/symfony-blog.rss')));
$documents2 = iterator_to_array($loader2->load('https://feeds.feedburner.com/symfony/blog'));

$this->assertCount(2, $documents1);
Expand Down
53 changes: 0 additions & 53 deletions demo/tests/Blog/LoaderTest.php
View file
Open in desktop

This file was deleted.

Loading