[Demo] Fix QueryCommand to use same embedding model as vectorizer
#619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use TEXT_ADA_002 for query embeddings to match the vectorizer configuration, ensuring consistent embedding models between indexing and querying for better similarity search results.
carsonbot
added
Demo
chr-hertel
approved these changes
Sep 17, 2025
OskarStark
added a commit
that referenced
this pull request
Sep 17, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [Demo] Leverage `Vectorizer` in `QueryCommand` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Replaces #619 | License | MIT Replace direct platform usage with `VectorizerInterface` injection using the `#[Autowire]` attribute for cleaner dependency management and better separation of concerns. Commits ------- 981ee06 [Demo] Leverage `Vectorizer` in `QueryCommand`
|
Replaced by #620 |
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 17, 2025
- Remove redundant `?? []` in AiBundle since config schema has defaults - Use `::class` constants instead of string literals in tests - Remove unnecessary echo from filter example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 17, 2025
- Remove redundant `?? []` in AiBundle since config schema has defaults - Use `::class` constants instead of string literals in tests - Remove unnecessary echo from filter example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 17, 2025
- Remove redundant `?? []` in AiBundle since config schema has defaults - Use `::class` constants instead of string literals in tests - Remove unnecessary echo from filter example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TEXT_ADA_002 for query embeddings to match the vectorizer configuration, ensuring consistent embedding models between indexing and querying for better similarity search results.