[Platform][DockerModelRunner] Add ModelNotFoundException
#628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Feature
OskarStark
changed the title
ModelNotFoundException
OskarStark
changed the title
ModelNotFoundExceptionModelNotFoundException
OskarStark
approved these changes
Sep 17, 2025
|
Thanks Mathieu for working on this feature, this is much appreciated. |
OskarStark
added a commit
that referenced
this pull request
Sep 17, 2025
…Exception` (OskarStark) This PR was merged into the main branch. Discussion ---------- [Platform][DockerModelRunner] Add tests for `ModelNotFoundException` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Follows #628 | License | MIT Tests verify that ModelNotFoundException is properly thrown when: - 404 response contains "model not found" message (case-insensitive) - Exception is not thrown for 404 responses without the specific message cc `@welcoMattic` Commits ------- f059335 Add tests for ModelNotFoundException in DockerModelRunner result converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #531
This PR introduce
ModelNotFoundException, useful for local model runners that return an error due to a non-existing model locally (typo in name or never downloaded model for instance).It must be used by Ollama and LmStudio bridges. PRs are welcome.