[Agent] Allow translatable prompts in SystemPromptInputProcessor
#635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
changed the title
carsonbot
changed the title
OskarStark
changed the title
SystemPromptInputProcessor
OskarStark
approved these changes
Sep 26, 2025
VincentLanglet
force-pushed
the
translatablePrompts
branch
5 times, most recently
from
cc2e7c8 to
03f004f
Compare
Indeed, I forgot the ci, it's fixed now @OskarStark. For the doc, #514 didn't introduce any so there is nothing to update. |
OskarStark
force-pushed
the
translatablePrompts
branch
from
03f004f to
868581f
Compare
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #514 with a suggestion of using TranslatableMessage instance for prompts rather than the need in SystemPromptInputProcessor constructor of
Since we're passing a TranslatableMessage this also allow to use translation parameters.
cc @OskarStark that was the suggestion in #514 (comment)