[AI Bundle] Add support for query parameters in model configuration #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
OskarStark
force-pushed
the
feature/model-query-parameters
branch
from
14fb5a5 to
c7d1db6
Compare
|
Is this for the DSN thingy or what are you aiming for? |
|
And for the model catalog to be able to modify options, as the bundle will not provide a model object anymore, just a plain string |
OskarStark
force-pushed
the
feature/model-query-parameters
branch
5 times, most recently
from
9e84931 to
e87ff52
Compare
- Enable two model configuration formats: 1. Query parameter style: model.name with ?key=value parameters 2. Separate options style: model.name and model.options array - Add validation to prevent using both formats simultaneously - Use parse_url() for parsing query parameters - Query parameter values remain as strings (no type conversion) - Update demo configuration and documentation - Add comprehensive test coverage for both formats
OskarStark
force-pushed
the
feature/model-query-parameters
branch
from
e87ff52 to
5d86763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.