[AI Bundle][Agent][Demo][Platform][Store] Remove Test Coverage Attributes #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
added
Agent
carsonbot
changed the title
OskarStark
approved these changes
Sep 23, 2025
|
demo CI is failing |
chr-hertel
force-pushed
the
remove-test-coverage-attributes
branch
from
d0b0b69 to
3421070
Compare
OskarStark
added a commit
that referenced
this pull request
Sep 24, 2025
…arStark) This PR was squashed before being merged into the main branch. Discussion ---------- [PHPStan] Add rule to forbid test coverage attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Follows #647 | License | MIT This rule prevents the use of Large, Small, Medium, CoversClass and UsesClass attributes in test files, helping maintain consistency in the test codebase by avoiding these coverage-related attributes. The rule operates only on files ending with 'Test.php' and provides clear error messages with tips for resolving violations. ### Proof <img width="1602" height="1292" alt="CleanShot 2025-09-24 at 07 18 01@2x" src="https://github.com/user-attachments/assets/0f60461f-c429-4bf3-a364-c051e6f1b686" /> Commits ------- b8f4abe [PHPStan] Add rule to forbid test coverage attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not using it, and Symfony usually also skips those information. And coverage is outdated and nearly impossible to review.