Skip to content

[AI Bundle] Fix null model names #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
+46 −50
Merged

[AI Bundle] Fix null model names #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ai-bundle/config/options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
->thenInvalid(\sprintf('The model class "%%s" must extend %s.', Model::class))
->end()
->end()
->stringNode('name')->defaultNull()->end()
->stringNode('name')->isRequired()->end()
->arrayNode('options')
->variablePrototype()->end()
->end()
Expand Down Expand Up @@ -531,7 +531,7 @@
->thenInvalid(\sprintf('The model class "%%s" must extend %s.', Model::class))
->end()
->end()
->stringNode('name')->defaultNull()->end()
->stringNode('name')->isRequired()->end()
->arrayNode('options')
->variablePrototype()->end()
->end()
Expand Down
8 changes: 2 additions & 6 deletions src/ai-bundle/src/AiBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,7 @@ private function processAgentConfig(string $name, array $config, ContainerBuilde
['class' => $modelClass, 'name' => $modelName, 'options' => $options] = $config['model'];

$modelDefinition = new Definition($modelClass);
if (null !== $modelName) {
$modelDefinition->setArgument(0, $modelName);
}
$modelDefinition->setArgument(0, $modelName);
if ([] !== $options) {
$modelDefinition->setArgument(1, $options);
}
Expand Down Expand Up @@ -1105,9 +1103,7 @@ private function processVectorizerConfig(string $name, array $config, ContainerB
['class' => $modelClass, 'name' => $modelName, 'options' => $options] = $config['model'];

$modelDefinition = (new Definition((string) $modelClass));
if (null !== $modelName) {
$modelDefinition->setArgument(0, $modelName);
}
$modelDefinition->setArgument(0, $modelName);
if ([] !== $options) {
$modelDefinition->setArgument(1, $options);
}
Expand Down
Loading
Loading