[PHPStan] Add rule to forbid empty() usage and replace all existing empty() calls #663
+72
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 24, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | no |
| Issues | -- |
| License | MIT |
OskarStark
force-pushed
the
avoid-empty
branch
from
26fcc34 to
0340b92
Compare
|
You might want to consider using PHPStan's strict rules plugin, see https://github.com/phpstan/phpstan-strict-rules/blob/2.0.x/src/Rules/DisallowedConstructs/DisallowedEmptyRule.php |
Thanks for the hint and I am aware of it, but right now I want to allow empty in |
OskarStark
added a commit
that referenced
this pull request
Sep 24, 2025
…rict-rules `DisallowEmptyRule` (OskarStark) This PR was squashed before being merged into the main branch. Discussion ---------- [PHPStan] Replace custom `ForbidEmptyRule` with phpstan-strict-rules `DisallowEmptyRule` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Reworks #663 | License | MIT Commits ------- 1aeb98d [PHPStan] Replace custom `ForbidEmptyRule` with phpstan-strict-rules `DisallowEmptyRule`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.