Skip to content

Import FQCNs in examples instead of using inline class names #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Import FQCNs in examples instead of using inline class names #666

merged 1 commit into from
Sep 24, 2025
+4 −2

Conversation

OskarStark
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Docs? no
Issues --
License MIT

@OskarStark
Import FQCNs in examples instead of using inline class names
2c65b97 
- Add proper use statements for TokenOutputProcessor in vertexai/token-metadata.php
- Add proper use statement for ChromaDB\Factory in rag/chromadb.php
- Replace inline FQCN usage with imported class names for better readability
@OskarStark OskarStark self-assigned this Sep 24, 2025
@carsonbot carsonbot changed the title Import FQCNs in examples instead of using inline class names Import FQCNs in examples instead of using inline class names Sep 24, 2025
@OskarStark OskarStark merged commit 498c256 into symfony:main Sep 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

Assignees

@OskarStark OskarStark

Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @carsonbot