[Platform][Anthropic] Modify Claude constructor max_tokens handling
#668
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 24, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Docs? | no |
| Issues | Follows #667 |
| License | MIT |
carsonbot
added
Feature
Only add max_tokens => 1000 if not already present in options. Preserve existing max_tokens values when provided. Add test coverage for the max_tokens handling logic.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Claude constructor to handle max_tokens parameter more flexibly by setting a default value internally rather than in the constructor parameter.
- Changed constructor default parameter from
['max_tokens' => 1000]to empty array - Added internal logic to set
max_tokensto 1000 if not provided in options - Added comprehensive test coverage for the new behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/src/Bridge/Anthropic/Claude.php | Modified constructor to conditionally set max_tokens default internally |
| src/platform/tests/Bridge/Anthropic/ClaudeTest.php | Added test cases covering default, custom with max_tokens, and custom without max_tokens scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.