[Platform][Ollama] Better regex for qwen tool pattern #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnymilton
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Feature
carsonbot
changed the title
sonnymilton
force-pushed
the
ollama-qwen-size-regex
branch
from
0e401c8 to
f8e328b
Compare
|
Thank you @sonnymilton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex for QWEN models does not cover model size notation like
qwen3:32borqwen3-coder:32b.I changed the regular expression to support notations with model sizes.