Refactor examples to use print_stream helper function
#677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract repeated streaming pattern into reusable print_stream function in examples/bootstrap.php and update all streaming examples to use it. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
carsonbot
changed the title
print_stream helper functionprint_stream helper function
|
naaah, not sure tbh, we're now extracting code from the example that is actually helpful to understand what's going on - i feel like this harms the meaning of the example same for other |
|
Ok, so shall I revert? |
|
we can discuss in #693 - it's not the only one, but let's see how we move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract repeated streaming pattern into reusable print_stream function in examples/bootstrap.php and update all streaming examples to use it.