[Platform] Refactor catalog to use external models.php file
#699
+683
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
- Extract model definitions to src/Bridge/OpenAi/Resources/models.php - Update ModelCatalog to load models from external file at runtime - Improve maintainability and organization - All tests passing (28 ModelCatalog tests, 131 OpenAI bridge tests)
OskarStark
force-pushed
the
refactor-openai-model-catalog
branch
from
45a9963 to
d238fb2
Compare
- Add models.schema.json with complete JSON Schema definition - Enhance PHPDoc with detailed capability documentation - Reference schema file for IDE support and validation - All model classes and capabilities documented inline
- Create Model class with constants for all OpenAI model identifiers - Add @phpstan-type OpenAiModelName with literal union types - Override getModel() with detailed documentation - Add tests to verify constants match catalog models - Enable full IDE autocompletion for model names in PhpStorm
- Create bin/generate-model-schema.php to generate JSON schema from models.php - Automatically extract classes and capabilities from models - Update schema pattern to support dots in model names (e.g., gpt-4.1) - Script can be run manually or integrated into CI/CD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models.phpModelCatalogto load models from external file at runtime