[AI Bundle] Add parsing of model names with colon notation in config #714
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnymilton
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
sonnymilton
changed the title
OskarStark
approved these changes
Oct 1, 2025
carsonbot
changed the title
OskarStark
reviewed
Oct 1, 2025
| 'model' => $model, | ||
| ], | ||
| ], | ||
| ], |
There was a problem hiding this comment.
please add this logic also for the vectorizer.name.model config
OskarStark
approved these changes
Oct 2, 2025
carsonbot
changed the title
OskarStark
force-pushed
the
ai-bundle-config-model-name-parse
branch
from
cd6aa19 to
56714f3
Compare
|
Thank you @sonnymilton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #712, support for Ollama models with colon notation was added.
However, in the bundle configuration,
parse_url()incorrectly treated the part before the colon as a URI scheme and discarded it.As a result, model names were normalized to an empty or incomplete string, causing configuration errors.
This change ensures that model names written in colon notation are preserved correctly when parsing bundle configuration, allowing proper usage of Ollama models in Symfony projects.