[Platform] Support boolean string conversion in AbstractModelCatalog::parseModelName()
#718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnymilton
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Bug
OskarStark
approved these changes
Oct 2, 2025
…::parseModelName()`
OskarStark
force-pushed
the
model-options-boolean-strings
branch
from
b3241b0 to
f57c279
Compare
|
Thank you @sonnymilton for taking care of this regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the query parameter normalization logic in
AbstractModelCatalogto handle boolean-like strings ("true"/"false") in addition to numeric strings:?think=trueor?think=falseare now correctly converted to PHP booleans instead of remaining plain strings.parse_str()also normalize their boolean values.Tests
New test cases were added to ensure:
true/false).