[Store] Unify Vectorizer methods into single vectorize() method
#732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
OskarStark
force-pushed
the
OskarStark/vectorize-unification
branch
3 times, most recently
from
bb3255d to
6bb6631
Compare
paulinevos
reviewed
Oct 6, 2025
OskarStark
force-pushed
the
OskarStark/vectorize-unification
branch
4 times, most recently
from
8100e60 to
a7a843b
Compare
OskarStark
force-pushed
the
OskarStark/vectorize-unification
branch
from
9109db1 to
3fa8960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace separate vectorizeTextDocuments() and vectorize(string) methods with a single vectorize() method that handles:
Add PHPStan conditional return types for proper type inference. Add validation to ensure arrays contain only strings or TextDocuments. Update all usages across codebase including tests and examples.
cc @paulinevos