[Platform] Make BinaryResult properties private with getters
#736
+74
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Feature
OskarStark
force-pushed
the
OskarStark/binary-result-getters
branch
from
b5ed543 to
d2e39e1
Compare
- Changed data and mimeType properties from public to private - Added getData() and getMimeType() getter methods - Updated all test files to use new getter methods instead of direct property access - Added comprehensive BinaryResultTest with tests for all methods including the new getters
OskarStark
force-pushed
the
OskarStark/binary-result-getters
branch
from
d2e39e1 to
c58508c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.