-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: use final classes #1409
Conversation
In my apps, I usually declare all classes So 👍🏻 from my side. |
The only problem I see is that the maker bundle doesn't put the final keyword on controllers. |
3421c18
to
d24a930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem I see is that the maker bundle doesn't put the final keyword on controllers.
@weaverryan should we use final for controllers in maker bundle?
d24a930
to
180fa15
Compare
There are good reasons to use final by default. Can we explain with a comment somewhere is this project? |
This practice is very common in Symfony apps, so let's merge this. Thanks Loïc! |
|
Hello, these classes could be
final
right? (except the entities)(just done one example, will do the other if it is OK)