-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce config option for root directory #243
Comments
@simshaun I so do agree with this feature request! The new SF 4 project structure is great, but I’m currently a bit annoyed by the fact that Flex can’t support another «Symfony root». I generally design my projects with the help of the Hexagonal/Clean architecture, so everything Symfony-related is generally stored into As a side note, I have the same problem with the Anyway, I’m willing to help if this becomes green-lighted by the community! |
@simshaun I agree as well. I am introducing Symfony 4 into a legacy application, moving old source code to the new environment bit by bit, having Symfony installed unter |
Implemented in #448 |
…mfony app (nicolas-grekas) This PR was merged into the 1.1-dev branch. Discussion ---------- Allow configuring the "extra.symfony.root-dir" of the Symfony app Fixes #243 and makes path management a bit more flexible. Commits ------- 186bee1 Allow configuring the "extra.symfony.root-dir" of the Symfony app
This is a continuation of #236 -- there are still many instances of
getcwd()
.https://github.com/symfony/flex/blob/master/src/Flex.php
(copies
.env.dist to .env
)https://github.com/symfony/flex/blob/master/src/Configurator/CopyFromPackageConfigurator.php
https://github.com/symfony/flex/blob/master/src/Configurator/CopyFromRecipeConfigurator.php
https://github.com/symfony/flex/blob/master/src/Configurator/EnvConfigurator.php
https://github.com/symfony/flex/blob/master/src/Configurator/GitignoreConfigurator.php
https://github.com/symfony/flex/blob/master/src/Configurator/MakefileConfigurator.php
They all assume that the file/dir paths they need are relative to the dir composer is executed from. For my personal needs that's fine, but I'm wondering if some people could need that to be configurable.
For that, I think a new config option (e.g. something like
root-dir
) would need to be introduced.Thoughts? I will open a PR if this is something others are interested in.
The text was updated successfully, but these errors were encountered: