Leverage ext-curl when possible to achieve high speed downloads #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jan 11, 2018
src/ParallelDownloader.php
Outdated
| } | ||
|
|
||
| protected function callbackGet($notificationCode, $severity, $message, $messageCode, $bytesTransferred, $bytesMax) | ||
| public function callbackGet($notificationCode, $severity, $message, $messageCode, $bytesTransferred, $bytesMax) |
There was a problem hiding this comment.
Should we tag it as being @internal?
|
PR ready, works GREAT! |
|
PR ready for another try. All good on my side. Now able to do concurrent downloads on more files than prestissimo. As such, prestissimo is now disabled if found. |
fabpot
approved these changes
Jan 17, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 17, 2018
…wnloads (nicolas-grekas) This PR was merged into the 1.0-dev branch. Discussion ---------- Leverage ext-curl when possible to achieve high speed downloads This PR brings hirak/prestissimo-like download performance to Flex, but with greater compatibility with Composer's native behavior, thanks to a new extension point that is going to be part of Composer 1.7 (composer/composer#6985). Meanwhile, it already provides concurrent connections, and auto-enables the curl-based downloader conditionally. In short, it should be totally seamless. Commits ------- 58364b1 Leverage ext-curl when possible to achieve high speed downloads
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings hirak/prestissimo-like download performance to Flex, but with greater compatibility with Composer's native behavior, thanks to a new extension point that is going to be part of Composer 1.7 (composer/composer#6985).
Meanwhile, it already provides concurrent connections, and auto-enables the curl-based downloader conditionally.
In short, it should be totally seamless.