Skip to content

Fixed directory separator trimming in vendors path #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fixed directory separator trimming in vendors path #797

merged 1 commit into from
Sep 21, 2021

Conversation

skmedix
Copy link
Contributor

@skmedix skmedix commented Sep 6, 2021 •
edited
Loading

Fixes #796

We don't need to use \DIRECTORY_SEPARATOR here, as symfony/filesystem already normalizes windows directory separator to use forward slash.

@nicolas-grekas
Copy link
Member

Thank you @skmedix.

@nicolas-grekas nicolas-grekas merged commit 6c13a9e into symfony:main Sep 21, 2021
@skmedix skmedix deleted the fix/796 branch September 21, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vendor's directory separator is not trimmed on Windows
2 participants
@skmedix @nicolas-grekas