Skip to content

[Flex] Fix Composer update exception when flex://defaults missing #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

[Flex] Fix Composer update exception when flex://defaults missing #838

merged 1 commit into from
Nov 29, 2021

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 1.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #836
License MIT
Doc PR -

@nicolas-grekas
Copy link
Member

Hmm, on the other side, an endpoint that doesn't declare splits is likely broken as that means the extra.symfony.require entry will not work.
Maybe we should throw instead?

@gnito-org
Copy link
Contributor Author

Which specific exception would be the most appropriate to throw?

@nicolas-grekas
Copy link
Member

A LogicException would be fine to me.

@gnito-org
Copy link
Contributor Author

gnito-org commented Nov 28, 2021 •
edited
Loading

I changed the PR to throw a LogicException.

nicolas-grekas
nicolas-grekas reviewed Nov 28, 2021
View reviewed changes
@nicolas-grekas
Copy link
Member

Thank you @gnito-org.

@nicolas-grekas nicolas-grekas merged commit 7a79135 into symfony:1.x Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composer update exception when flex://defaults missing
2 participants
@gnito-org @nicolas-grekas