Skip to content

Conversation

toxaw
Copy link

@toxaw toxaw commented Nov 27, 2020

Testing options:
'/a/b',
'a/b',
'a/b/',
'/a/b/',

When updating packages in one of my project, a bug was caught where sentry/sdk v 2.2.0 in the new version uses this package, for this reason, the start of checking the work of the sentry, the completion occurred with a memory overflow.

@symfony-bot
Copy link

symfony-bot bot commented Nov 27, 2020

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply.

@nicolas-grekas
Copy link
Member

Thanks for your PR @toxaw
Can you please submit the PR against the https://github.com/symfony/symfony repository, branch 4.4?

Note that I tried your test cases, and they are green already without your patch on removeDotSegments.
We'd need test cases that fail without the patch before merging anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants