Skip to content

Mark XML configuration tests as legacy #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

Mark XML configuration tests as legacy #541

merged 1 commit into from
Oct 3, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 2, 2025

Q A
Branch? 3.x
Bug fix? no (test only)
New feature? no
Deprecations? no (deprecated by Symfony itself)
Issues Related to symfony/symfony#60568
License MIT

Hide deprecation notices on Symfony 7.4 without asserting the deprecation message:

  13x: Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.
    1x in XmlMonologExtensionTest::testLoadWithSeveralHandlers from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testLoadWithOverwriting from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testLoadWithNewAtEnd from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testLoadWithNewAndPriority from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testHandlersWithChannels from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    ...

Remaining indirect deprecation notices (3)

  3x: Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.
    1x in XmlMonologExtensionTest::testLoadWithOverwriting from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testLoadWithNewAtEnd from Symfony\Bundle\MonologBundle\Tests\DependencyInjection
    1x in XmlMonologExtensionTest::testLoadWithNewAndPriority from Symfony\Bundle\MonologBundle\Tests\DependencyInjection

@GromNaN GromNaN requested a review from HypeMC October 3, 2025 07:16
GromNaN
GromNaN commented Oct 3, 2025
View reviewed changes
@GromNaN GromNaN force-pushed the legacy-xml-config branch from 79e9be6 to 78b5730 Compare October 3, 2025 07:54
@GromNaN GromNaN merged commit 804df4a into symfony:3.x Oct 3, 2025
8 checks passed
GromNaN
GromNaN commented Oct 3, 2025
View reviewed changes
tests/DependencyInjection/XmlMonologExtensionTest.php
/**
* XML configuration deprecated since Symfony 7.4.
*
* @group legacy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the annotation with an attribute in upstream merge: d4f240d

@GromNaN GromNaN mentioned this pull request Oct 3, 2025
Merged
@GromNaN GromNaN deleted the legacy-xml-config branch October 3, 2025 08:54
GromNaN added a commit that referenced this pull request Oct 3, 2025
@GromNaN
minor #543 Skip XML config tests with Symfony 8.0 (GromNaN)
863c5e4 
This PR was merged into the 4.x branch.

Discussion
----------

Skip XML config tests with Symfony 8.0

| Q             | A
| ------------- | ---
| Branch?       | 4.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Related to symfony/symfony#60568
| License       | MIT

Follow-up:
- #541

As soon as we keep support for Symfony 7.4, we must keep the tests on XML config format.

Commits
-------

3d3b625 Skip XML config tests with Symfony 8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HypeMC HypeMC HypeMC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @HypeMC