Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalizer_get_raw_decomposition function #126

Open
IonBazan opened this issue May 12, 2018 · 4 comments
Open

Add normalizer_get_raw_decomposition function #126

IonBazan opened this issue May 12, 2018 · 4 comments

Comments

@IonBazan
Copy link
Contributor

I would be good to support normalizer_get_raw_decomposition function that appeared in PHP 7.3. I've tried to implement it but seems that existing decomposition data is already optimized to get the final decomposition. Example test case is available here.
Pinging @nicolas-grekas as he is the author of Normalizer polyfill.

@nicolas-grekas
Copy link
Member

Would be great :) and you're right, the map is optimized for normalization. We need to ship a separate map to be able to provide the intermediate decompositions.

@IonBazan
Copy link
Contributor Author

@nicolas-grekas Can you provide the steps you've took to generate normalization mapping? Is there any script available to base on? What do you think about commiting the script into the repository?

@nicolas-grekas
Copy link
Member

@nicolas-grekas
Copy link
Member

Note that the compilation script is now part of the repo:
https://github.com/symfony/polyfill/blob/master/tests/Compiler.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants