Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UUID] Added support for V3 and V5 #236

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 3, 2020

Note: on old libuuid version, the V5 format is broken. Ubuntu 18.04 is affected.
This has been fixed here.

You can test your distribution with:

uuidgen -s -n ec07aa88-f84e-47b9-a581-1c6b30a2f484 -N "the name"

You must got:

851def0c-b9c7-55aa-a991-130e769ec0a9

Some tests:

// python:          851def0c-b9c7-55aa-a991-130e769ec0a9
// go:              851def0c-b9c7-55aa-a991-130e769ec0a9
// ramsey:          851def0c-b9c7-55aa-a991-130e769ec0a9
// sf:              851def0c-b9c7-55aa-a991-130e769ec0a9
// libuuid 19.10:   851def0c-b9c7-55aa-a991-130e769ec0a9
// libbuuid arch:   851def0c-b9c7-55aa-a991-130e769ec0a9
// libuuid 18.04:   851def0c-b9c7-55aa-8991-130e769ec0a9
// pecl 18.0.4:     851def0c-b9c7-55aa-8991-130e769ec0a9

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Mar 3, 2020

Thank you @lyrixx.

@fabpot fabpot merged commit 4d0b530 into symfony:master Mar 3, 2020
@lyrixx lyrixx deleted the uuid-sha-md5 branch March 3, 2020 14:05
@stof
Copy link
Member

stof commented Mar 3, 2020

@lyrixx shouldn't you also update the implementation of uuid_create to support these types ?

@lyrixx
Copy link
Member Author

lyrixx commented Mar 3, 2020

I already looked at this, and I don't think so.
V3 and V5 requires more arguments.
That's why (I guess) Remi created 2 new functions instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants