Skip to content

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented May 18, 2018

Executable finder should consider "executable" suffixes first on Windows because we basically ignore executability on Windows (line 80 below the change), which leads, for example, to finding usually-non-executable phpunit file first where both phpunit and phpunit.bat are present.

Executable finder should consider "executable" suffixes first on Windows because we basically ignore executability on Windows (line 80 below the change), which leads, for example, to finding usually-non-executable `phpunit` file first where both `phpunit` and `phpunit.bat` are present.
@symfony-bot
Copy link

symfony-bot bot commented May 18, 2018

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant